Config drives created on RHEL/CentOS 7.1 can't be found

[ubuntu-server-builder]

This bug was originally filed in Launchpad as LP: #1598783

Launchpad details

affected_projects = ['cirros', 'cloudbase-init']
assignee = penick
assignee_name = James Penick
date_closed = 2018-02-22T22:32:56.260669+00:00
date_created = 2016-07-04T10:04:39.832255+00:00
date_fix_committed = 2018-01-23T21:22:55.478436+00:00
date_fix_released = 2018-02-22T22:32:56.260669+00:00
id = 1598783
importance = medium
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1598783
milestone = None
owner = penick
owner_name = James Penick
private = False
status = fix_released
submitter = rpodolyaka
submitter_name = Roman Podoliaka
tags = []
duplicates = []

Launchpad user Roman Podoliaka(rpodolyaka) wrote on 2016-07-04T10:04:39.832255+00:00

Depending on the exact version of dosfstools used when preparing a config drive FS, it may not be detected by Cirron on VM boot. This is due to the fact, that Cirros currently performs a case-sensitive comparison of FS labels:

http://bazaar.launchpad.net/~cirros-dev/cirros/trunk/view/head:/src/lib/cirros/shlib#L134

and mkfs.vfat from CentOS will create an uppercase label "CONFIG-2".

Apparently, dosfstools won't let you use lowercase labels on CentOS, while it works fine on Ubuntu:

http://paste.openstack.org/show/507193/

All the descriptions of the config drive format mention "config-2", not "CONFIG-2":

http://cloudinit.readthedocs.io/en/latest/topics/datasources.html
https://coreos.com/os/docs/latest/config-drive.html
http://docs.openstack.org/user-guide/cli_config_drive.html

Nothing is said about whether case-sensitive or -insensitive string comparison should be used for comparing of FS labels.

Looks like FAT standard does not specify how labels should be treated, but Windows (at least XP) stores those in upper-case:

"For FAT volumes, volume labels are stored as uppercase regardless of whether they contain lowercase letters. NTFS volume labels retain and display the case used when the label was created."

https://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-us/label.mspx?mfr=true

E.g. in Debian this was considered to be a bug and was fixed:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=714971;msg=2

It even was accepted to upstream:

dosfstools/dosfstools@465dd8c

and made it to 3.0.22 release.

Related bug in MOS: https://bugs.launchpad.net/mos/+bug/1587960

[ubuntu-server-builder]

Launchpad user Roman Podoliaka(rpodolyaka) wrote on 2016-07-04T10:05:07.848312+00:00

This should help, checking it right now
Launchpad attachments: config_drive.patch

[ubuntu-server-builder]

Launchpad user OpenStack Infra(hudson-openstack) wrote on 2017-12-21T01:37:48.311764+00:00

Fix proposed to branch: master
Review: https://review.openstack.org/529448

[ubuntu-server-builder]

Launchpad user Scott Moser(smoser) wrote on 2018-02-22T22:32:57.376030+00:00

This bug is believed to be fixed in cloud-init in 18.1. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

[ubuntu-server-builder]

Launchpad user OpenStack Infra(hudson-openstack) wrote on 2018-02-27T17:19:54.367174+00:00

Reviewed: https://review.openstack.org/529448
Committed: https://git.openstack.org/cgit/openstack/cloudbase-init/commit/?id=24365043e31a7cb0899d2222bbba654ef718da5b
Submitter: Zuul
Branch: master

commit 24365043e31a7cb0899d2222bbba654ef718da5b
Author: James Penick penick@yahoo-inc.com
Date: Thu Dec 21 01:16:41 2017 +0000

Recognize uppercase vfat disk labels

New mkfs.vfat and fatlabel tools included in the dosfsutils package no
longer support creating vfat disks with lowercase labels. They silently
default to an all uppercase label eg CONFIG-2 instead of config-2. This
change makes cloud-init handle either upper or lower case.

Change-Id: Iec927db04b9621b20c9bee2c8d81325d7af80f9b
Closes-Bug: #1598783