Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maas datasource needs support for vendor-data #2707

Closed
ubuntu-server-builder opened this issue May 10, 2023 · 8 comments
Closed

maas datasource needs support for vendor-data #2707

ubuntu-server-builder opened this issue May 10, 2023 · 8 comments
Labels
launchpad Migrated from Launchpad

Comments

@ubuntu-server-builder
Copy link
Collaborator

This bug was originally filed in Launchpad as LP: #1612313

Launchpad details
affected_projects = ['cloud-init (Ubuntu)', 'cloud-init (Ubuntu Xenial)']
assignee = smoser
assignee_name = Scott Moser
date_closed = 2016-09-12T20:50:03.471791+00:00
date_created = 2016-08-11T15:40:05.752000+00:00
date_fix_committed = 2016-08-12T18:41:48.355321+00:00
date_fix_released = 2016-09-12T20:50:03.471791+00:00
id = 1612313
importance = medium
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1612313
milestone = None
owner = smoser
owner_name = Scott Moser
private = False
status = fix_released
submitter = smoser
submitter_name = Scott Moser
tags = ['verification-done']
duplicates = []

Launchpad user Scott Moser(smoser) wrote on 2016-08-11T15:40:05.752000+00:00

==== Begin SRU Template ====
[Impact]
This is a new feature adding 'vendor data' support to MAAS.
MAAS in 2.X will make use of this feature in cloud-init.

[Test Case]
There are unit tests to test this, actual integration test is not easily
done outside of MAAS.

[Regression Potential]
Very low chance of regression. Cloud-init will try once to retrive
vendor-data and if it is present use it. If not, it will go on.

The regression possibility would then be in cases when interacting
with old maas if the request failed causing cloud-init to fail.
In testing of yakkety, this has not been seen to be a problem.
==== End SRU Template ====

maas datasource does not support vendor-data.
We would like to take advantage of vendordata in maas, and thus cloud-init needs it.

@ubuntu-server-builder ubuntu-server-builder added the launchpad Migrated from Launchpad label May 10, 2023
@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Scott Moser(smoser) wrote on 2016-08-12T18:48:04.325259+00:00

This is fixed in d9537aa

cloud-init will now support MAAS having a 'vendor-data' key under meta-data/.
If it is present and non-empty, then it must be yaml loadable string (recognize that json is valid yaml, so sending json is valid).

The object represented by the yaml should be a dictionary with a 'cloud-init' key.

Example valid data to affect the 'packages' setting, would be:

{
"cloud-init": "#cloud-config\npackages=['pastebinit']\n",
"this-key-is-ignored": "something here"
}

Note that the 'cloud-init' is a string. It is not a dictionary.
It can also be a list, in which case each of the pieces will be consumed as a cloud-init part (much as it would read multipart-mime input).

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Scott Moser(smoser) wrote on 2016-09-12T20:50:02.167718+00:00

fixed in 0.7.8.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Chris J Arges(arges) wrote on 2016-09-13T20:16:49.210764+00:00

Hello Scott, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.7-31-g65ace7b-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Andres Rodriguez(andreserl) wrote on 2016-09-14T20:45:45.302419+00:00

We've tested this an proven it works as expected. Marking verification-done.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Martin Pitt(pitti) wrote on 2016-09-15T14:30:30.461866+00:00

Hello Scott, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.8-1-g3705bb5-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Scott Moser(smoser) wrote on 2016-09-17T02:34:33.764315+00:00

this is still functioning in 0.7.8-1-g3705bb5-0ubuntu1~16.04.1 for maas.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Launchpad Janitor(janitor) wrote on 2016-09-22T17:34:08.065412+00:00

This bug was fixed in the package cloud-init - 0.7.8-1-g3705bb5-0ubuntu1~16.04.1


cloud-init (0.7.8-1-g3705bb5-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

  • New upstream release 0.7.8.
  • New upstream snapshot.
    • systemd: put cloud-init.target After multi-user.target (LP: #1623868)

cloud-init (0.7.7-31-g65ace7b-0ubuntu1~16.04.2) xenial-proposed; urgency=medium

  • debian/control: add Breaks of older versions of walinuxagent (LP: #1623570)

cloud-init (0.7.7-31-g65ace7b-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

  • debian/control: fix missing dependency on python3-serial,
    and make SmartOS datasource work.
  • debian/cloud-init.templates fix capitalisation in template so
    dpkg-reconfigure works to select OpenStack. (LP: #1575727)
  • d/README.source, d/control, d/new-upstream-snapshot, d/rules: sync
    with yakkety for changes due to move to git.
  • d/rules: change PYVER=python3 to PYVER=3 to adjust to upstream change.
  • debian/rules, debian/cloud-init.install: remove install file
    to ensure expected files are collected into cloud-init deb.
    (LP: #1615745)
  • debian/dirs: remove obsolete / unused file.
  • upstream move from bzr to git.
  • New upstream snapshot.
    • Allow link type of null in network_data.json [Jon Grimm] (LP: #1621968)
    • DataSourceOVF: fix user-data as base64 with python3 (LP: #1619394)
    • remove obsolete .bzrignore
    • systemd: Better support package and upgrade. (LP: #1576692, #1621336)
    • tests: cleanup tempdirs in apt_source tests
    • apt config conversion: treat empty string as not provided. (LP: #1621180)
    • Fix typo in default keys for phone_home [Roland Sommer] (LP: #1607810)
    • salt minion: update default pki directory for newer salt minion.
      (LP: #1609899)
    • bddeb: add --release flag to specify the release in changelog.
    • apt-config: allow both old and new format to be present.
      [Christian Ehrhardt] (LP: #1616831)
    • python2.6: fix dict comprehension usage in _lsb_release. [Joshua Harlow]
    • Add a module that can configure spacewalk. [Joshua Harlow]
    • add install option for openrc [Matthew Thode]
    • Generate a dummy bond name for OpenStack (LP: #1605749)
    • network: fix get_interface_mac for bond slave, read_sys_net for ENOTDIR
    • azure dhclient-hook cleanups
    • Minor cleanups to atomic_helper and add unit tests.
    • Fix Gentoo net config generation [Matthew Thode]
    • distros: fix get_primary_arch method use of os.uname [Andrew Jorgensen]
    • Apt: add new apt configuration format [Christian Ehrhardt]
    • Get Azure endpoint server from DHCP client [Brent Baude]
    • DigitalOcean: use the v1.json endpoint [Ben Howard]
    • MAAS: add vendor-data support (LP: #1612313)
    • Upgrade to a configobj package new enough to work [Joshua Harlow]
    • ConfigDrive: recognize 'tap' as a link type. (LP: #1610784)
    • NoCloud: fix bug providing network-interfaces via meta-data.
      (LP: 1577982)
    • Add distro tags on config modules that should have it [Joshua Harlow]
    • ChangeLog: update changelog for previous commit.
    • add ntp config module [Ryan Harper]
    • SmartOS: more improvements for network configuration
    • tools/read-version: update to address change in version
    • make-tarball: older versions of git with --format=tar.
    • read-version: do not attempt git-describe if no git.
    • Newer requests have strong type validation [Joshua Harlow]
    • For upstream snapshot versions do not modify git-describe output.
    • adjust signal_handler for version changes.
    • revert unintended change to ubuntu sources list
    • drop modification of version during make-tarball, tools changes.
    • adjust tools and version information.
    • Update build tools to work with git [Lars Kellogg-Stedman]
    • fix pep8 errors in mcollective unit tests
    • mcollective: add tests, cleanups and bug fix when no config in /etc.

-- Scott Moser smoser@ubuntu.com Thu, 15 Sep 2016 09:57:27 -0400

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Chris J Arges(arges) wrote on 2016-09-22T17:35:27.001991+00:00

The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launchpad Migrated from Launchpad
Projects
None yet
Development

No branches or pull requests

1 participant