Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identification of e24cloud platform as using Ec2 datasource #2925

Closed
ubuntu-server-builder opened this issue May 11, 2023 · 8 comments
Closed
Labels
launchpad Migrated from Launchpad

Comments

@ubuntu-server-builder
Copy link
Collaborator

This bug was originally filed in Launchpad as LP: #1696476

Launchpad details
affected_projects = []
assignee = None
assignee_name = None
date_closed = 2019-12-19T22:59:58.899610+00:00
date_created = 2017-06-07T15:53:19.129503+00:00
date_fix_committed = 2019-10-11T14:54:54.337153+00:00
date_fix_released = 2019-12-19T22:59:58.899610+00:00
id = 1696476
importance = low
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1696476
milestone = None
owner = m-gibula
owner_name = Marcin Gibula
private = False
status = fix_released
submitter = m-gibula
submitter_name = Marcin Gibula
tags = []
duplicates = []

Launchpad user Marcin Gibula(m-gibula) wrote on 2017-06-07T15:53:19.129503+00:00

Hi,

I'd like to ask you, to add identification for e24cloud platform (e24cloud.com) with Ec2 Datasource.

It can be identified via system vendor field:

cat /sys/class/dmi/id/sys_vendor

e24cloud

dmidecode --string=system-manufacturer

e24cloud

I'll be happy to test a patch.

@ubuntu-server-builder ubuntu-server-builder added the launchpad Migrated from Launchpad label May 11, 2023
@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Ryan Harper(raharper) wrote on 2019-07-19T21:30:36.573570+00:00

Hi, If you'd like to test something out, you can look at some of the other EC2 Look Alike classes, like AliYun.

https://git.launchpad.net/cloud-init/tree/cloudinit/sources/DataSourceAliYun.py

And the commit where this landed shows the other changes needed (tools/ds-identify)

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Launchpad Janitor(janitor) wrote on 2019-09-18T04:17:35.816967+00:00

[Expired for cloud-init because there has been no activity for 60 days.]

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Scott Moser(smoser) wrote on 2019-09-18T13:44:11.596909+00:00

@marcin,
I've attached a branch, would you be able to test that?

Sorry for the 2 year delay.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Marcin Gibula(m-gibula) wrote on 2019-09-19T14:28:55.763414+00:00

Wow, that's unexpected:-)
I'm out of office until wednesday, will test it when I get back.

Thanks!

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Scott Moser(smoser) wrote on 2019-10-08T16:16:14.910331+00:00

@marcin,
Are you able to check?
I'm pretty sure I've implemented the code correctly, but it would sure be nice if we had someone verify that before landing it.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Marcin Gibula(m-gibula) wrote on 2019-10-09T09:11:41.742048+00:00

Hi,
yes, from what I've tested, it detects Ec2 datasource correctly.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Server Team CI bot(server-team-bot) wrote on 2019-10-11T14:54:52.839176+00:00

This bug is fixed with commit 7d5d34f to cloud-init on branch master.
To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=7d5d34f3

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Chad Smith(chad.smith) wrote on 2019-12-19T23:00:00.056940+00:00

This bug is believed to be fixed in cloud-init in version 19.2-57. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launchpad Migrated from Launchpad
Projects
None yet
Development

No branches or pull requests

1 participant