New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eni rendering broken for bridge params that require repeated key for values #2961
Comments
Launchpad user Scott Moser(smoser) wrote on 2017-07-26T19:36:12.004904+00:00 Launchpad attachments: Dependencies.txt,JournalErrors.txt,ProcCpuinfoMinimal.txt |
Launchpad user Chris J Arges(arges) wrote on 2017-08-23T12:29:15.668498+00:00 Hello Scott, or anyone else affected, Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-233-ge586fe35-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! |
Launchpad user Chris J Arges(arges) wrote on 2017-08-23T12:32:18.188759+00:00 Hello Scott, or anyone else affected, Accepted cloud-init into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-233-ge586fe35-0ubuntu1~17.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! |
Launchpad user Chad Smith(chad.smith) wrote on 2017-08-28T22:09:16.262435+00:00 validated xenial and zesty network configuration output with net-convert.pycsmith@fringe:~$ for release in xenial zesty; do
DISTRIB_CODENAME=xenial
Internal State Input YAML
Internal State auto lo iface eth0 inet manual iface eth1 inet manual iface br0 inet manual network:
Internal State Input YAML
Internal State auto lo iface eth0 inet manual iface eth1 inet manual iface br0 inet manual network: |
Launchpad user Launchpad Janitor(janitor) wrote on 2017-09-13T01:26:05.837714+00:00 This bug was fixed in the package cloud-init - 0.7.9-233-ge586fe35-0ubuntu1~16.04.1 cloud-init (0.7.9-233-ge586fe35-0ubuntu1~16.04.1) xenial-proposed; urgency=medium
-- Scott Moser smoser@ubuntu.com Mon, 31 Jul 2017 16:36:16 -0400 |
Launchpad user Chris Halse Rogers(raof) wrote on 2017-09-13T01:27:07.724615+00:00 The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions. |
Launchpad user Launchpad Janitor(janitor) wrote on 2017-09-13T01:27:27.937540+00:00 This bug was fixed in the package cloud-init - 0.7.9-233-ge586fe35-0ubuntu1~17.04.1 cloud-init (0.7.9-233-ge586fe35-0ubuntu1~17.04.1) zesty; urgency=medium
-- Scott Moser smoser@ubuntu.com Mon, 31 Jul 2017 16:33:24 -0400 |
Launchpad user Scott Moser(smoser) wrote on 2017-09-22T21:09:46.021731+00:00 This is believed fixed in 17.1. |
This bug was originally filed in Launchpad as LP: #1706752
Launchpad details
Launchpad user Scott Moser(smoser) wrote on 2017-07-26T19:36:12.004904+00:00
=== Begin SRU Template ===
[Impact]
ENI rendering of bridge configuration options for bridge_pathcost, bridge_portprio and bridge_waitport would be limited to a single key/val pair. Now support multi-line key values for these configuration options.
[Test Case]
if [ ! -f lxc-proposed-snapshot ]; then
wget https://git.launchpad.net/~smoser/cloud-init/+git/sru-info/plain/bin/lxc-proposed-snapshot -O lxc-proposed-snapshot
chmod 755 lxc-proposed-snapshot
fi
get render tool
$ wget https://git.launchpad.net/~cloud-init-dev/cloud-init/plain/tools/net-convert.py -O net-convert.py
write the network_data.json
$ cat >network_data.yaml <<EOF
version: 1
config:
- type: physical
name: eth0
mac_address: "c0:d6:9f:2c:e8:80"
- type: physical
name: eth1
mac_address: "aa:d6:9f:2c:e8:80"
- type: bridge
name: br0
bridge_interfaces:
- eth0
- eth1
params:
bridge_ageing: 250
bridge_bridgeprio: 22
bridge_fd: 1
bridge_gcint: 2
bridge_hello: 1
bridge_maxage: 10
bridge_maxwait: 0
bridge_pathcost:
- eth0 50
- eth1 75
bridge_portprio:
- eth0 28
- eth1 14
bridge_stp: 'off'
bridge_waitport:
- 1 eth0
- 2 eth1
EOF
for release in xenial zesty; do
ref=$release-proposed;
echo "$release START --------------";
./lxc-proposed-snapshot --proposed --publish $release $ref;
lxc start test-$release;
lxc file push net-convert.py test-$release/net-convery.py;
lxc file push network_data.yaml test-$release/network_data.yaml;
for k in eni netplan; do
lxc exec test-$release -- python3 /net-convert.py
--network-data=net-config.yaml --kind=yaml
--output-kind=$k --mac=eth0,c0:d6:9f:2c:e8:80
--directory=out.d ;
done
lxc exec test-$release -- cat out.d/etc/network/interfaces
lxc exec test-$release -- cat out.d/etc/netplan/50-cloud-init.yaml
done
[Regression Potential]
Fairly low, this feature adds support for multi-line keys for 3 specific bridge configuration options bridge_pathcost, bridge_portprio and bridge_waitport.
Prior releases didn't have this support and would have only allowed for a single configuration value for the key. Now the configuration is properly rendered for multiple-interfaces.
[Other Info]
Upstream commit at
https://git.launchpad.net/cloud-init/commit/?id=00b678c61
This is fixed in cloud-init via commit 00b678c.
Fix eni rendering for bridge params that require repeated key for values.
There are a few bridge parameters which require repeating the key with each
value in the list when rendering eni. Extend the network unittests to cover
all of the known bridge parameters and check we render eni and netplan
correctly.
ProblemType: Bug
DistroRelease: Ubuntu 17.04
Package: cloud-init 0.7.9-90-g61eb03fe-0ubuntu1
ProcVersionSignature: Ubuntu 4.10.0-26.30-generic 4.10.17
Uname: Linux 4.10.0-26-generic x86_64
NonfreeKernelModules: zfs zunicode zavl zcommon znvpair
ApportVersion: 2.20.4-0ubuntu4.5
Architecture: amd64
Date: Wed Jul 26 19:33:36 2017
PackageArchitecture: all
ProcEnviron:
TERM=xterm-256color
PATH=(custom, no user)
LANG=C.UTF-8
SourcePackage: cloud-init
UpgradeStatus: No upgrade log present (probably fresh install)
The text was updated successfully, but these errors were encountered: