test_net.TestGenerateFallbackConfig.test_unstable_names is sensitive to host environment

[ubuntu-server-builder]

This bug was originally filed in Launchpad as LP: #1769952

Launchpad details

affected_projects = []
assignee = None
assignee_name = None
date_closed = 2018-06-20T18:06:06.128455+00:00
date_created = 2018-05-08T16:57:29.938354+00:00
date_fix_committed = 2018-05-10T02:36:53.411587+00:00
date_fix_released = 2018-06-20T18:06:06.128455+00:00
id = 1769952
importance = medium
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1769952
milestone = None
owner = larsks
owner_name = Lars Kellogg-Stedman
private = False
status = fix_released
submitter = larsks
submitter_name = Lars Kellogg-Stedman
tags = []
duplicates = []

Launchpad user Lars Kellogg-Stedman(larsks) wrote on 2018-05-08T16:57:29.938354+00:00

The test_unstable_names test expects cloudinit.util.udevadm_settle to be called once:

self.assertEqual(1, mock_settle.call_count)

But cloudinit.net.find_fallback_nic inspects /proc/cmdline for the net.ifnames=0 parameter, and if found will not call udevadm_settle, which causes the test to fail.

The unit tests should not rely on information from the host environment.

[ubuntu-server-builder]

Launchpad user Chad Smith(chad.smith) wrote on 2018-05-10T02:36:51.872232+00:00

An upstream commit landed for this bug.

To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=3b712fce

[ubuntu-server-builder]

Launchpad user Scott Moser(smoser) wrote on 2018-06-20T18:06:07.075732+00:00

This bug is believed to be fixed in cloud-init in version 18.3. If this is still a problem for you, please make a comment and set the state back to New

Thank you.