Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-init should not treat MAC addresses as case sensitive #3672

Open
ubuntu-server-builder opened this issue May 12, 2023 · 3 comments
Open
Labels
bug Something isn't working correctly launchpad Migrated from Launchpad

Comments

@ubuntu-server-builder
Copy link
Collaborator

This bug was originally filed in Launchpad as LP: #1876363

Launchpad details
affected_projects = []
assignee = None
assignee_name = None
date_closed = None
date_created = 2020-05-01T19:12:49.938843+00:00
date_fix_committed = None
date_fix_released = None
id = 1876363
importance = low
is_complete = False
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1876363
milestone = None
owner = bospoort
owner_name = GM van de Bospoort
private = False
status = triaged
submitter = bospoort
submitter_name = GM van de Bospoort
tags = []
duplicates = []

Launchpad user GM van de Bospoort(bospoort) wrote on 2020-05-01T19:12:49.938843+00:00

Currently, cloud-init can run into issues applying network configuration if the MAC addresses reported by the system are in a different case to the MAC addresses provided by the network configuration source. It is likely that there are also other places where a mismatch could happen. We should ensure that cloud-init's MAC address handling is not case sensitive.

[Original Report]

I'm using an ISO with the following yaml in network-config. cloud-init will not match eth0, but will match eth1 due to capitalization.

version: 2
ethernets:
  eth0:
    match:
      macaddress: 00:15:5D:0E:AE:0C
    set-name: External
  eth1:
    match:
      macaddress: 00:15:5d:0e:ae:0d
    set-name: Internal

RuntimeError: Not all expected physical devices present: {'00:15:5D:0E:AE:0C'}

cloudinit/net/init.py, Line 545, in wait_for_physdevs.

Can you either fix the documentation to explicitly require lower case (this page has several uppe case references: https://cloudinit.readthedocs.io/en/latest/topics/network-config-format-v2.html). Or do the lower case conversion in wait_for_physdevs when you compare the present_macs to the expected_macs?

@ubuntu-server-builder ubuntu-server-builder added bug Something isn't working correctly launchpad Migrated from Launchpad labels May 12, 2023
@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Dan Watkins(oddbloke) wrote on 2020-05-05T15:12:08.863343+00:00

Hi,

Thanks for the bug report! I've filed bug 1876941 specifically for the documentation changes you suggested, and I'm going to rework this bug report slightly to cover fixing the underlying problem.

Dan

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user GM van de Bospoort(bospoort) wrote on 2020-05-05T15:35:23+00:00

Thank you Dan. Let me know if I can help.

-----Original Message-----
From: bounces@canonical.com bounces@canonical.com On Behalf Of Dan Watkins
Sent: Tuesday, May 5, 2020 8:12 AM
To: Maarten Van De Bospoort maartenb@microsoft.com
Subject: [EXTERNAL] [Bug 1876363] Re: network-config macaddress needs to be lower case

Hi,

Thanks for the bug report! I've filed bug 1876941 specifically for the documentation changes you suggested, and I'm going to rework this bug report slightly to cover fixing the underlying problem.

Dan

** Summary changed:

  • network-config macaddress needs to be lower case
  • cloud-init should not treat MAC addresses as case sensitive

--
You received this bug notification because you are subscribed to the bug report.
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fbugs%2F1876363&data=02%7C01%7Cmaartenb%40microsoft.com%7Ce43f93cc5a5647f3b23c08d7f107e211%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637242889007745276&sdata=gw9hXhRhb37rAlU%2Foe%2Fvx7RoLMY46kzu%2BhW3YjlMbKc%3D&reserved=0

Title:
cloud-init should not treat MAC addresses as case sensitive

Status in cloud-init:
New

Bug description:
I'm using an ISO with the following yaml in network-config. cloud-init
will not match eth0, but will match eth1 due to capitalization.

version: 2
ethernets:
eth0:
match:
macaddress: 00:15:5D:0E:AE:0C
set-name: External
eth1:
match:
macaddress: 00:15:5d:0e:ae:0d
set-name: Internal

RuntimeError: Not all expected physical devices present:
{'00:15:5D:0E:AE:0C'}

cloudinit/net/init.py, Line 545, in wait_for_physdevs.

Can you either fix the documentation to explicitly require lower case
(this page has several uppe case references:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcloudinit.readthedocs.io%2Fen%2Flatest%2Ftopics%2Fnetwork-config-&data=02%7C01%7Cmaartenb%40microsoft.com%7Ce43f93cc5a5647f3b23c08d7f107e211%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637242889007745276&sdata=KxLgXJ9%2B%2FOdt3P2e3Sb0%2BAnVK6SSMmXNgmQYSbtdcng%3D&reserved=0
format-v2.html). Or do the lower case conversion in wait_for_physdevs
when you compare the present_macs to the expected_macs?

To manage notifications about this bug go to:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fcloud-init%2F%2Bbug%2F1876363%2F%2Bsubscriptions&data=02%7C01%7Cmaartenb%40microsoft.com%7Ce43f93cc5a5647f3b23c08d7f107e211%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637242889007745276&sdata=92P5Nf7lbKS5Xtl25nRRigMf%2FUvliYAidnsiyGhzBT8%3D&reserved=0

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user James Falcon(falcojr) wrote on 2022-04-26T18:43:07.864642+00:00

Since we've updated the docs to accurately specify and show examples of lowercase, I'm demoting the importance of dealing with the rest of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly launchpad Migrated from Launchpad
Projects
None yet
Development

No branches or pull requests

1 participant