Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py is not PEP517 compliant #3986

Open
ubuntu-server-builder opened this issue May 12, 2023 · 5 comments
Open

setup.py is not PEP517 compliant #3986

ubuntu-server-builder opened this issue May 12, 2023 · 5 comments
Labels
bug Something isn't working correctly launchpad Migrated from Launchpad

Comments

@ubuntu-server-builder
Copy link
Collaborator

This bug was originally filed in Launchpad as LP: #1978328

Launchpad details
affected_projects = []
assignee = None
assignee_name = None
date_closed = None
date_created = 2022-06-10T15:57:48.990151+00:00
date_fix_committed = None
date_fix_released = None
id = 1978328
importance = medium
is_complete = False
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1978328
milestone = None
owner = holmanb
owner_name = Brett Holman
private = False
status = triaged
submitter = holmanb
submitter_name = Brett Holman
tags = []
duplicates = []

Launchpad user Brett Holman(holmanb) wrote on 2022-06-10T15:57:48.990151+00:00

A bug[1] was filed downstream for this, and reported upstream in #cloud-init IRC by Sam (Gentoo maintainer).

This causes build failure on Gentoo/OpenRC, which is carrying a downstream workaround[2] for now.

It looks like the upstream installation method for init scripts and additional bits (non-Python files at all) isn't compatible with PEP517, so PEP517 installs are broken right now.

PEP517 with the wheel spec doesn't have a good way of installing data files.

[1] https://bugs.gentoo.org/850628
[2] gentoo/gentoo@44cfdb3

@ubuntu-server-builder ubuntu-server-builder added bug Something isn't working correctly launchpad Migrated from Launchpad labels May 12, 2023
@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Brett Holman(holmanb) wrote on 2022-06-11T04:47:03.353253+00:00

Launchpad attachments: good.log

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Brett Holman(holmanb) wrote on 2022-06-11T04:47:30.949233+00:00

Launchpad attachments: bad.log

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Brett Holman(holmanb) wrote on 2022-06-11T04:53:08.624166+00:00

From Sam, after sharing the logs:

There's a hint of it at the very end because you see the chmod fails (there was a missing die in the ebuild).

run:

python -m build -C--init-system=openrc # no, that's not a typo, no space after 'C'
python3 -m installer dist/cloud*.whl --destdir=/tmp/foo

/tmp/foo/* only contains the usr/bin and usr/lib/*

@prometheanfire
Copy link
Contributor

looks like this is still an issue :(

may be removed from gentoo because of it

https://bugs.gentoo.org/909872

@holmanb
Copy link
Member

holmanb commented Mar 8, 2024

@prometheanfire thanks for the ping

I was just working on the upstream support for this today, will try to get this fixed asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly launchpad Migrated from Launchpad
Projects
None yet
Development

No branches or pull requests

3 participants