-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] support key by url in apt configure module #4076
Comments
I would like to work on this issue :) |
@kaiwalyakoparkar , we'll welcome the contribution. At the moment, nobody else is working on this, so feel free to work on it. |
@TheRealFalcon Thank you so much! I would like to know about the issue and maybe what folder and files should I be looking at while working on this issue? Also references or other material to understand the issue would be appreciated :) |
The target is to add to the To do so, we would need to extend the config section associated to the module in the lines of the issue's example and implement it. One way to implement it would be to use apt-key, but this command is deprecated, see the man page. Please, let us know if you, @kaiwalyakoparkar, need more support. Referencescc_apt_configure - documentation |
Thank you so much @aciba90 I will start working on it and would let you'll know if I face any issue, Kindly assign this to me :D |
Preferably this would use/share existing code rather than use If I remember correctly, we already have a function in |
The schema is the place where we define what config keys are allowed per config module, and config modules receive an instance of the configuration and react appropriately to them. In this case, we have to:
You can find the python modules here: cloudinit.util and cloudinit.url_helper. |
Hey folks, just wanted to update you that, I might not able to work on this issue for a while due to my exams. I will resume working on it as soon as my exams are over :) |
Folks, I am back from exams. Thanks for understanding. I will start working on this issue :) |
@aciba90 and/or @holmanb Could I get some insight / feedback on these updates to the schema? Following @holmanb's comment, I wanted to make sure that the schema accurately reflected that certain keys conflict when present in an Also, while I was in there I took the liberty of updating the top-level If the preference is that changes to that schema def are as minor as possible I can absolutely roll them back. If y'all confirm that they're correct and leaving them in won't impact the PR's acceptance though, I will obviously just leave 'em be. |
@the-wondersmith sorry I missed your earlier comment. Could you please open a PR with your changes? Also did you sign the CLA? It looks like you are on the right track with your work here, and your commit history looks clean - we should be able to do fast-forward merge.
I think you're right - I expect adding them as you have would be better, but maybe @TheRealFalcon had a reason not to add them at the time. Either way, lets continue the conversation in a PR once you've opened it. |
They were. The current structure is the way it is because we generate documentation off of our schema. Originally, we didn't have a top-level |
Absolutely, will do as soon as I have some free time
Yessir, I did 😁
💪
Sounds good |
This bug was originally filed in Launchpad as LP: #2006775
Launchpad details
Launchpad user Brett Holman(holmanb) wrote on 2023-02-09T19:08:55.982578+00:00
A common way of distributing keys is by hosting them at a URL for download. This is not currently supported by the apt configure module, and would be a simple addition.
Example usage (note the suggested 'keyurl' key)
The text was updated successfully, but these errors were encountered: