Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/Group keys with dashes not included in schema #5187

Open
TheRealFalcon opened this issue Apr 18, 2024 · 2 comments
Open

User/Group keys with dashes not included in schema #5187

TheRealFalcon opened this issue Apr 18, 2024 · 2 comments
Labels
bug Something isn't working correctly

Comments

@TheRealFalcon
Copy link
Member

Bug report

Due to some unfortunate old code, every users/groups key in our user data allows for both underscores and dashes. For example, if we define the key as ssh_authorized_keys, then ssh-authorized-keys is also valid.

The schema for all of the user and group properties contains the _ version of the key but not the - version. The schema needs to be updated to allow both while specifying that the - version is deprecated.

#5162 already does this for ssh-authorized-keys, but we should do it for the remaining keys to be consistent.

@TheRealFalcon TheRealFalcon added bug Something isn't working correctly new An issue that still needs triage labels Apr 18, 2024
@afbjorklund
Copy link
Contributor

afbjorklund commented Apr 19, 2024

The ca-certs was fixed earlier, but we weren't using schema back then so it was noticed and changed manually...

  • Continue to honor deprecated config keys but emit DEPRECATION
    warnings in logs for continued use of the deprecated keys:
    • apt_sources key
    • any apt v1 or v2 keys
    • use or ca-certs or ca_certs.remove-defaults
    "cc_ca_certs": {
      "type": "object",
      "properties": {
        "ca_certs": {
          "$ref": "#/$defs/ca_certs.properties"
        },
        "ca-certs": {
          "allOf": [
            {
              "$ref": "#/$defs/ca_certs.properties"
            },
            {
              "deprecated": true,
              "deprecated_version": "22.3",
              "deprecated_description": "Use ``ca_certs`` instead."
            }
          ]
        }
      }
    },

@CalvoM
Copy link
Contributor

CalvoM commented Apr 25, 2024

@CalvoM CalvoM removed the new An issue that still needs triage label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants