Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 21.1 #820

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Release 21.1 #820

merged 1 commit into from
Feb 23, 2021

Conversation

OddBloke
Copy link
Collaborator

Proposed Commit Message

Release 21.1

Bump the version in cloudinit/version.py to 21.1 and
update ChangeLog.

LP: #1916540

Additional Info

Due to the 20.4.1 hotfix, a couple of manual modifications to our automated output were made. The merge commit was removed from the changelog, and the automatically incremented version was fixed up (from 21.1.1).

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My diff. Based on your comments I'm assuming I should expect this.

diff --git a/ChangeLog b/ChangeLog
index b23437a2..a8c96a1e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -23,0 +24 @@
+ - Merge upstream/20.4.1 into master
diff --git a/cloudinit/version.py b/cloudinit/version.py
index 94afd60d..2fe28021 100644
--- a/cloudinit/version.py
+++ b/cloudinit/version.py
@@ -7 +7 @@
-__VERSION__ = "21.1"
+__VERSION__ = "21.1.1"

We didn't release 20.4.1 upstream, did we? If we did, then we can skip the two commits for the revert commit and release for that.

Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 and can confirm we wanted to set 21.1 instead of 21.1.1, the tooling didn't expect to deal w/ hotfix "patch" version as you mentioned.

@OddBloke
Copy link
Collaborator Author

My diff. Based on your comments I'm assuming I should expect this.

diff --git a/ChangeLog b/ChangeLog
index b23437a2..a8c96a1e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -23,0 +24 @@
+ - Merge upstream/20.4.1 into master
diff --git a/cloudinit/version.py b/cloudinit/version.py
index 94afd60d..2fe28021 100644
--- a/cloudinit/version.py
+++ b/cloudinit/version.py
@@ -7 +7 @@
-__VERSION__ = "21.1"
+__VERSION__ = "21.1.1"

We didn't release 20.4.1 upstream, did we? If we did, then we can skip the two commits for the revert commit and release for that.

We did release 20.4.1 upstream, it's actually already in this changelog. I've removed the repeated lines:

--- a/ChangeLog
+++ b/ChangeLog
@@ -35,10 +35,6 @@
  - Use proper spelling for Red Hat (#778) [Dan Kenigsberg]
  - Add antonyc to .github-cla-signers (#747) [Anton Chaporgin]
  - integration_tests: log image serial if available (#772)
- - Revert "ssh_util: handle non-default AuthorizedKeysFile config (#586)"
-   (#775)
- - Release 20.4.1 (LP: #1911680)
- - Revert "ssh_util: handle non-default AuthorizedKeysFile config (#586)"
  - [VMware] Support cloudinit raw data feature (#691) [xiaofengw-vmware]
  - net: Fix static routes to host in eni renderer (#668) [Pavel Abalikhin]
  - .travis.yml: don't run cloud_tests in CI (#756)

Bump the version in cloudinit/version.py to 21.1 and
update ChangeLog.

LP: #1916540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants