Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory spike when taking snapshot #281

Closed
ktsakalozos opened this issue Jan 26, 2021 · 1 comment
Closed

Memory spike when taking snapshot #281

ktsakalozos opened this issue Jan 26, 2021 · 1 comment
Assignees
Labels
Bug Confirmed to be a bug

Comments

@ktsakalozos
Copy link
Member

Periodically and under certain conditions [1] dqlite will take a snapshot [2]. The snapshot ends up copying the memory used in vfs [3] and for a short period of time the memory usage increases by hundreds of MB subject to the dataset. Maybe we should find a way to get this snapshot without spiking the memory? Not sure if this is possible, I am reporting this behavior in case it tips us over in memory constrained environments.

[1] https://github.com/canonical/raft/blob/master/src/replication.c#L1368
[2] https://github.com/canonical/raft/blob/master/src/replication.c#L1410
[3] https://github.com/canonical/dqlite/blob/master/src/vfs.c#L2427

@stgraber stgraber added the Bug Confirmed to be a bug label Apr 21, 2021
@MathieuBordere
Copy link
Contributor

MathieuBordere commented Apr 28, 2022

#356 should provide a lot of improvement for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed to be a bug
Projects
None yet
Development

No branches or pull requests

3 participants