Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose an operation to remove a node from the cluster #250

Closed
cole-miller opened this issue May 3, 2023 · 2 comments
Closed

Expose an operation to remove a node from the cluster #250

cole-miller opened this issue May 3, 2023 · 2 comments

Comments

@cole-miller
Copy link
Contributor

cole-miller commented May 3, 2023

We've had a request from the Juju team to add an API in go-dqlite for removing a node from the cluster configuration (as opposed to just demoting it, which automatic role management should handle if the node has become inactive). We already have this operation in the dqlite wire protocol, so it's just a matter of finding the appropriate place to add it in go-dqlite and making sure it doesn't interact badly with anything else.

@freeekanayaka
Copy link
Contributor

Should be:

https://pkg.go.dev/github.com/canonical/go-dqlite@v1.11.9/client#Client.Remove

and possibly:

https://pkg.go.dev/github.com/canonical/go-dqlite@v1.11.9/app#App.Leader

to automatically get a Client object connected to the cluster leader.

@cole-miller
Copy link
Contributor Author

Good point! I've passed that along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants