Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydantic 2.0 dependency #214

Closed
jneo8 opened this issue Jul 3, 2023 · 2 comments · Fixed by #215
Closed

pydantic 2.0 dependency #214

jneo8 opened this issue Jul 3, 2023 · 2 comments · Fixed by #215

Comments

@jneo8
Copy link
Contributor

jneo8 commented Jul 3, 2023

Bug Description

The pydantic just released 2.0.
So the charm build and and the PY_DEPS in library is broken.
Also maybe some fixs are requried for pydantic related code.

To Reproduce

tox -e render-machine
charmcraft pack

Environment

ubuntu 20.04

Relevant log output

...

Temporary workaround

Pin pydantic version < 2.0 in PY_DEPS

# PYDEPS = ["cosl", "pydantic"]
PYDEPS = ["cosl", "pydantic < 2.0"]

Additional context

No response

@PietroPasotti
Copy link
Contributor

just had the same issue in tempo, had to pin it to "<2.0" and it worked for now

@dragomirp
Copy link
Contributor

Hi, at the moment clean builds of charms using lib/charms/grafana_agent/v0/cos_agent.py would try to pull pydantic 2.0 and fail to pack at least on focal. This happens because charmcraft is updating dependencies based on what is specified in the PYDEPS of charm libs. There's a bug canonical/charmcraft#1135 open for it, but short term charm libs should most probably pin the major version in PYDEPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants