Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logic in _on_config_changed event #215

Open
chanchiwai-ray opened this issue Apr 5, 2024 · 0 comments
Open

Clean up logic in _on_config_changed event #215

chanchiwai-ray opened this issue Apr 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@chanchiwai-ray
Copy link
Contributor

The _on_config_changed event has a few issues that might cause unexpected behaviors in some corner cases:

  1. The defer() function is called without a return follow immediately, which is not what defer suppose to do
  2. When cos_agent relation is missing, the config changed event will not render the config file; even when the cos_agent relation is joined, the previous config changed event will not fire again. This cause a loss of config changed event when cos_agent relation is missing.
@chanchiwai-ray chanchiwai-ray added bug Something isn't working enhancement New feature or request labels Apr 5, 2024
@Pjack Pjack removed the enhancement New feature or request label Apr 8, 2024
@Pjack Pjack added enhancement New feature or request and removed bug Something isn't working labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants