Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Katib ROCKs to 0.16-rc.1 for CKF release 1.8 #31

Closed
orfeas-k opened this issue Sep 21, 2023 · 4 comments · Fixed by #33
Closed

Update Katib ROCKs to 0.16-rc.1 for CKF release 1.8 #31

orfeas-k opened this issue Sep 21, 2023 · 4 comments · Fixed by #33
Labels
enhancement New feature or request

Comments

@orfeas-k
Copy link
Contributor

This issue tracks the process of updating Katib ROCKs to Katib's 0.16 for CKF release 1.8. For the process, we 're following our internal Kubeflow ROCK Images Best Practices that has a section about Upgrade of ROCK Images.

The changes that this process will introduce should match what the upstream has for version v0.16-rc.1.

@orfeas-k orfeas-k added this to Needs Triage in MLOps Solution Issues via automation Sep 21, 2023
@orfeas-k orfeas-k added the enhancement New feature or request label Sep 21, 2023
@orfeas-k orfeas-k moved this from Needs Triage to Labeled in MLOps Solution Issues Sep 21, 2023
@orfeas-k
Copy link
Contributor Author

cert-generator

Upstream has consolidated the katib-cert-generator component into the katib controller. Thus, there is no Dockerfile for it in 0.16-rc.1. We should remove it from main and keep it in the katib-rocks branch for CKF 1.7 (we haven't cut that yet).

@orfeas-k
Copy link
Contributor Author

katib-db-manager

db-manager Dockerfile has introduced the following changes

5d4
< ENV GRPC_HEALTH_PROBE_VERSION v0.4.15
21,24d19
< # Add GRPC health probe.
< RUN wget -qO /bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-${TARGETARCH} \
<   && chmod +x /bin/grpc_health_probe
< 
28d22
< COPY --from=build-env /bin/grpc_health_probe /bin/

which is expected according to canonical/katib-operators#122 (comment). Thus, we will not introduce those changes in the ROCK.

@orfeas-k
Copy link
Contributor Author

katib-ui-rock

We need to rewrite the ROCK due to it being based on the wrong dockerfile #32.

@orfeas-k
Copy link
Contributor Author

grpc health checks

As discussed here, we 're following what was done upstream and removing the binary for health checks since

this type of ROCK images are not managed by charms. GRPC checks will be peformed by K8S on this images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant