Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation of parameters on LogProxyConsumer lib #226

Closed
zmraul opened this issue Dec 16, 2022 · 0 comments · Fixed by #249
Closed

Improve validation of parameters on LogProxyConsumer lib #226

zmraul opened this issue Dec 16, 2022 · 0 comments · Fixed by #249
Labels
Status: Triage Type: Bug

Comments

@zmraul
Copy link

zmraul commented Dec 16, 2022

Enhancement Proposal

Passing a string instead of a list doesn't lead to any errors from the lib:

self.loki_push = LogProxyConsumer(self, log_files="my/log/file.log", ...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type check the log_files arg canonical/loki-k8s-operator
2 participants
@simskij @zmraul