Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I would consider delegating this concern to a separate class, for example #27

Closed
Abuelodelanada opened this issue Oct 13, 2021 · 2 comments
Closed

I would consider delegating this concern to a separate class, for example #27

Abuelodelanada opened this issue Oct 13, 2021 · 2 comments
Labels
Status: Cannot Reproduce Type: Invalid

Comments

@Abuelodelanada
Copy link
Contributor

I would consider delegating this concern to a separate class, for example

alerts = list(map(LokiAlertRule.from_file, Path(self._alert_rules_path).glob("*.rule")))

Originally posted by @sed-i in #25 (comment)
@Abuelodelanada
Copy link
Contributor Author

Also: Too deep nesting.

@simskij
Copy link
Member

simskij commented Apr 13, 2022

Issue is stale and the original code is no longer present in HEAD. Closing.

@simskij simskij closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Cannot Reproduce Type: Invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Abuelodelanada @simskij