Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gzip and security header for documentation and API endpoints #13150

Closed
edlerd opened this issue Mar 14, 2024 · 2 comments · Fixed by #13164
Closed

Add gzip and security header for documentation and API endpoints #13150

edlerd opened this issue Mar 14, 2024 · 2 comments · Fixed by #13164
Assignees
Labels
Improvement Improve to current situation
Milestone

Comments

@edlerd
Copy link
Contributor

edlerd commented Mar 14, 2024

Required information

  • Distribution: snap
  • Distribution version: 5.21.0-0cbd19b

Issue description

The documentation served with LXD needs the same security headers as the UI received in #13100

Both documentation and all API endpoints should have support for gzip. Especially the 1.0/metadata/configuration and documentation/objects.inv.txt paths have large response payloads and would benefit from compression.

Steps to reproduce

Documentation

  1. Request local path GET /documentation
  2. Check security headers are present and gzip compression is enabled in the response

API endpoints

  1. Request API endpoint GET 1.0/metadata/configuration
  2. Check the response has gzip compression enabled.
@tomponline tomponline added this to the lxd-6.1 milestone Mar 14, 2024
@tomponline tomponline added the Improvement Improve to current situation label Mar 14, 2024
@gabrielmougard
Copy link
Contributor

@edlerd thanks

@gabrielmougard
Copy link
Contributor

@edlerd updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improve to current situation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants