Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should not autoselect noauto commissioning scripts #1498

Closed
webteam-app opened this issue Aug 21, 2020 · 2 comments · Fixed by #1488
Closed

UI should not autoselect noauto commissioning scripts #1498

webteam-app opened this issue Aug 21, 2020 · 2 comments · Fixed by #1488

Comments

@webteam-app
Copy link

Bug originally filed by ltrager at https://bugs.launchpad.net/bugs/1884827

In LP:1881919 a user requested the ability to upload commissioning scripts which do not automatically run. The backend will no longer automatically select any commissioning script tagged with "noauto". The UI is still selecting all commissioning scripts by default.

@sparkiegeek
Copy link
Contributor

sparkiegeek commented Feb 16, 2021

@cristinadresch @hatched can this be backported to 2.8? Or is that too tricky?

@sparkiegeek sparkiegeek reopened this Feb 16, 2021
@Caleb-Ellis
Copy link
Contributor

@sparkiegeek it's only a little bit tricky because we can't just cherry pick the commit (since we weren't using typescript in 2.8), but I doubt it'll be tooooo bad. I'll take a look today anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants