Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPMI Workaround "None" option should not be displayed and instead set when all other options are unset #3523

Closed
cpg1111 opened this issue Jan 17, 2022 · 2 comments · Fixed by #3636
Assignees
Labels

Comments

@cpg1111
Copy link

cpg1111 commented Jan 17, 2022

Describe the bug
In the multiselect for IPMI workaround options, there is a None option displayed, the explicit None value is used so that the CLI may unset the default value. However, the UI should hide this option and set it as a value when all other options are unset.

maas-ui version
HEAD

MAAS version
HEAD

LP issue
lp1958173

To Reproduce
Steps to reproduce the behavior:

  1. Add a machine with IPMI power management
  2. Configure IPMI options
  3. Notice the None workaround option

Expected behavior
All options except None are displayed and available for selection, if all of the displayed options are unset, the None option is selected.

Screenshots

Screenshot from 2022-01-17 14-44-37

Desktop (please complete the following information):

  • OS: Ubuntu 21.10
  • Browser Firefox
  • Version HEAD

Additional context
N/A

@Caleb-Ellis
Copy link
Contributor

@cpg1111 Is this something we can expect to be used in other multiselect power type fields or is this probably an IPMI-only thing? i.e. should we handle this dynamically or should we special-case IPMI here?

@cpg1111
Copy link
Author

cpg1111 commented Jan 17, 2022

At least for now, this is unique to the IPMI workaround options. We don't use multiselect for other power types currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants