Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to improve understanding #29

Open
Abuelodelanada opened this issue Mar 5, 2024 · 0 comments
Open

Add comments to improve understanding #29

Abuelodelanada opened this issue Mar 5, 2024 · 0 comments

Comments

@Abuelodelanada
Copy link
Contributor

          Wdyt about adding a line or two for a comment per role, giving charm-related context?

If this enum class is duplicated in the coordinator as well, then perhaps a discourse post to link to from here?

The idea is not comments like alertmanager is responsible for alerts, but rather something like (hypothetical): alertmanager is already included in 'all', and is a no-op if a 'ruler' is missing.

Separate issue probably :)

Originally posted by @sed-i in #28 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant