Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing a window brings one of the remaining windows of the same client to the front #3309

Open
Saviq opened this issue Apr 2, 2024 · 4 comments · May be fixed by #3385
Open

Closing a window brings one of the remaining windows of the same client to the front #3309

Saviq opened this issue Apr 2, 2024 · 4 comments · May be fixed by #3385
Labels
bug triaged Triage into JIRA to plan it in

Comments

@Saviq
Copy link
Collaborator

Saviq commented Apr 2, 2024 •
edited

Steps:

  • have two windows of App A open
  • have App B open
  • Alt+Tab to App B, then App A
  • close foreground App A window

Expected:

  • focus goes back to App B

Current:

  • focus goes to the other window of App A
@Saviq Saviq added the bug label Apr 2, 2024
@Saviq Saviq added the triaged Triage into JIRA to plan it in label Apr 10, 2024
@mattkae
Copy link
Contributor

mattkae commented May 8, 2024 •
edited

It looks like we raise all windows belonging to the same app when we're cycling apps, instead of just a single window, which is wrong

@AlanGriffiths
Copy link
Contributor

That is hard to read!

s/apps/windows/
s/types/app/

Maybe?

@mattkae
Copy link
Contributor

mattkae commented May 9, 2024

Even worse, BasicWindowManager::refocus also wants to handle refocus. That is probably where we want to move this logic anyway...

@mattkae
Copy link
Contributor

mattkae commented May 9, 2024

Although, if BasicWindowManager::refocus manages that behavior, then WindowManagers aren't free to do whatever they like in that situation. (e.g. maybe a Tiling Window Manager wants to select a window that's close to the last selected window, instead of the last focused one)

mattkae added a commit that referenced this issue May 9, 2024
@mattkae
(#3309) selecting a correct next window after the focused one is clos…
1d84931 
…ed or disabled
@mattkae mattkae linked a pull request May 9, 2024 that will close this issue
Open
mattkae added a commit that referenced this issue May 9, 2024
@mattkae
(#3309) selecting a correct next window after the focused one is clos…
d41c31e 
…ed or disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug triaged Triage into JIRA to plan it in
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#3309) selecting a correct next window after the focused one is closed or disabled canonical/mir
3 participants
@Saviq @AlanGriffiths @mattkae