Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] download progress flickering #1532

Closed
Saviq opened this issue May 13, 2020 · 0 comments · Fixed by #2979
Closed

[windows] download progress flickering #1532

Saviq opened this issue May 13, 2020 · 0 comments · Fixed by #2979
Assignees
@sharder996
Labels
bug medium medium importance
Milestone
1.12.0

Comments

@Saviq
Copy link
Collaborator

Saviq commented May 13, 2020

Describe the bug
Progress updates in all of cmd.exe, powershell, windows terminal cause flicker of the whole line. It looks that the line is updated more often than necessary.

To Reproduce

  1. Install Multipass fresh
  2. multipass launch

Expected behavior
Progress update only affects the terminal when the download percentage changes.

Additional info

  • OS: Windows 10
  • multipass-1.2.1
@Saviq Saviq added bug medium medium importance labels May 13, 2020
@sharder996 sharder996 mentioned this issue Mar 20, 2023
Merged
@sharder996 sharder996 self-assigned this Mar 20, 2023
@sharder996 sharder996 added this to the 1.12.0 milestone Mar 20, 2023
@bors bors bot closed this as completed in 29a575d Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharder996 sharder996

Labels
bug medium medium importance
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

[cli] Only update progress when percentage goes up canonical/multipass
2 participants
@Saviq @sharder996