-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate minimum resource errors #2925
Comments
Hi @sed-i, thank you for the suggestion. This is a really interesting problem. In general, returning all the errors with a command is a really difficult thing to do: recognising some errors requires an "understanding" of underlying constructs, but that is only possible if there were no earlier errors when parsing/interpreting/assembling those constructs. That's also why compilers only report certain errors after earlier phases passed. A practical example: in OK, but perhaps we could make a best effort to report as many errors as we can with the info we got? We could try, but that would still require a lot of work if we were to do it on a generic basis (diverting attention from other possible enhancements). Moreover, how far should we go? In the example above, should we contact the daemon to let it contact remotes to see if we can launch with image So you see, I would rather bail as soon as we can. It certainly simplifies things a lot. However, having discussed with @townsend2010, I do recognise that wasn't the best user experience you had there. But I guess the main reason is that it is difficult to know what those minima are. A compromise in this particular case would be to print all of them when any value is found to be below the minimum (but without pointing out remaining errors). Something like:
How does that sound? Do you think that would have been helpful? |
Thanks @ricab. I think your proposal fully addresses the enhancement proposal. |
We are going to change how blueprints handle this. Instead of being a hard fast minimum, it will instead be a default that can be overridden by the user at |
What are you trying to do?
Launch an instance with resources less than the blueprint minimum. Got 3 error messages before I was able to launch.
What's your proposed solution?
Print out all the "requires" resources that are lower than the "limit". For example:
Additional context
Currently it's one resource error message at a time:
The text was updated successfully, but these errors were encountered: