Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade_unit does match signature of abstract method #139

Closed
carlcsaposs-canonical opened this issue Apr 26, 2024 · 3 comments
Closed

upgrade_unit does match signature of abstract method #139

carlcsaposs-canonical opened this issue Apr 26, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@carlcsaposs-canonical
Copy link
Contributor

Mismatch between
upgrade_unit call in abstract_charm.py (type hinting is for abstract upgrade.py)

self._upgrade.upgrade_unit(
event=event,
workload_=workload_,
tls=self._tls_certificate_saved,
exporter_config=self._cos_exporter_config(event),
)

upgrade.py abstract upgrade_unit

@abc.abstractmethod
def upgrade_unit(self, *, workload_: workload.Workload, tls: bool) -> None:
"""Upgrade this unit.
Only applies to machine charm
"""

machine_upgrade.py upgrade_unit

def upgrade_unit(
self,
*,
event,
workload_: workload.Workload,
tls: bool,
exporter_config: "relations.cos.ExporterConfig",
) -> None:

@carlcsaposs-canonical carlcsaposs-canonical added the bug Something isn't working label Apr 26, 2024
Copy link

@carlcsaposs-canonical
Copy link
Contributor Author

@shayancanonical FYI; changed in #119

@shayancanonical
Copy link
Contributor

resolved in #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants