Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kratos redirect through HTTPS #49

Open
nsklikas opened this issue Dec 12, 2023 · 0 comments
Open

Kratos redirect through HTTPS #49

nsklikas opened this issue Dec 12, 2023 · 0 comments

Comments

@nsklikas
Copy link
Contributor

nsklikas commented Dec 12, 2023

Bug Description

Oathkeeper has 2 different interactions with Kratos:

  1. When it calls the sessions endpoint to check the validity of the user's cookie.
  2. When it redirects the user to Kratos to authenticate

In (1) it does not matter whether the request is done through HTTP or HTTPS (it should be over HTTPS after we have completed the end-to-end TLS story). In (2) the redirect needs to be over HTTPS, because the browser needs to set the Kratos secure cookies.

Currently both actions use HTTP. This means that to make it work, Kratos needs to run using the dev flag.

IMHO we should make the second call using the HTTPS ingress port and the first call using plain HTTP, until the end-to-end tls is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant