Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to proxy requests in backups #244

Open
Mehdi-Bendriss opened this issue Apr 19, 2024 · 3 comments
Open

Remove reference to proxy requests in backups #244

Mehdi-Bendriss opened this issue Apr 19, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Mehdi-Bendriss
Copy link
Contributor

The backups module makes use of a a proxy request method which handles empty, None, error responses in a special way.
We need to revisit this part and make the module converge with using exclusively the main request method.
@Mehdi-Bendriss Mehdi-Bendriss added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 19, 2024
@github-actions GitHub Actions
Copy link

https://warthogs.atlassian.net/browse/DPE-4161

@Mehdi-Bendriss Mehdi-Bendriss mentioned this issue Apr 19, 2024
Merged
@phvalguima
Copy link
Contributor

Hi @Mehdi-Bendriss do you mean actual proxy setup? Or a change on s3-integrator.

@Mehdi-Bendriss
Copy link
Contributor Author

@phvalguima i mean that the _request method in the backups module is a proxy function the request method of the opensearch_distro module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phvalguima @Mehdi-Bendriss