[DPE-4306] resume-upgrade does not work on leader as highest unit #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the leader happens to be the unit with highest id, then the `resume-upgrade` will fail. This PR broadens the health check to also consider `UnitState.UPGRADING` status as valid healthy status. Closes #303
carlcsaposs-canonical
requested changes
May 8, 2024
There was a problem hiding this comment.
consider
UnitState.UPGRADINGstatus as valid healthy status
this is not a healthy status—this means that the unit has refreshed the snap but has not come back online as healthy
the upgrade should not automatically resume or manually resume with resume-upgrade if the unit does not come back online as healthy (except for force upgrades)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the leader happens to be the unit with highest id, then the
resume-upgradewill fail.This PR broadens the health check to also consider
UnitState.UPGRADINGstatus as valid healthy status.Closes #303