Scaling #16
Merged
Scaling #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 1, 2022 16:06
…rator into remove-userlist
WRFitch
requested review from
delgod,
zmraul,
Mehdi-Bendriss,
shayancanonical,
MiaAltieri,
paulomach and
marcoppenheimer
paulomach
approved these changes
Sep 1, 2022
src/charm.py
Outdated
| """Charmed PgBouncer connection pooler.""" | ||
| """Charmed PgBouncer connection pooler. | ||
|
|
||
| TODO the flow of this charm is getting a bit convoluted. The backend relation has to be ready |
There was a problem hiding this comment.
This is not something to worry if you have a clear view on the conditions that are required at each step.
Making the conditions to run a hook (or defer when not met) as clear as possible will suffice.
There was a problem hiding this comment.
ok, I'd still like to try and simplify it but I'll document the requirements in the hook docstrings.
|
|
||
| from constants import AUTH_FILE_PATH, INI_PATH, PG_USER, PGB |
There was a problem hiding this comment.
is PGB the app name?
Suggested change
| from constants import AUTH_FILE_PATH, INI_PATH, PG_USER, PGB | |
| from constants import AUTH_FILE_PATH, INI_PATH, PG_USER, PGB_APP_NAME |
There was a problem hiding this comment.
it's the pgbouncer service name, so it's "pgbouncer", whereas the app name is "pgbouncer-k8s".
marceloneppel
approved these changes
Sep 2, 2022
marceloneppel
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Jira issue: DPE-472
This PR allows PgBouncer to scale to multiple units.
Context
Release Notes
Testing