Persist userlist and PGB config on controller restart #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2022 10:26
…rt to be more detailed
WRFitch
requested review from
shayancanonical,
taurus-forever,
paulomach,
MiaAltieri,
zmraul and
carlcsaposs-canonical
| @@ -68,7 +68,7 @@ commands = | |||
| description = Run all integration tests | |||
| deps = | |||
| pytest | |||
| juju | |||
| juju==2.9.11 # juju 3.0.0 has issues with retrieving action results | |||
There was a problem hiding this comment.
JFMI, why do we lock such an old juju version? 2.9.37 is the latest as for today.
There was a problem hiding this comment.
This is the last 2.9 version of libjuju, which doesn't follow the same version as juju :)
taurus-forever
previously approved these changes
Nov 16, 2022
marceloneppel
previously approved these changes
Nov 17, 2022
WRFitch
dismissed stale reviews from marceloneppel and taurus-forever
via
46f1145
added 11 commits
November 18, 2022 16:37
…om/canonical/pgbouncer-k8s-operator into persist-data-on-controller-restart
WRFitch
requested review from
marceloneppel,
taurus-forever and
carlcsaposs-canonical
marceloneppel
previously approved these changes
Nov 30, 2022
paulomach
approved these changes
Dec 1, 2022
marceloneppel
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
When we restart the k8s controller on which a PGB operator runs, we lose our containers and therefore our config. This PR checks the peer databag for config files if they aren't available in the filesystem.
Context
Release Notes
Testing