Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider alertmanager interface name #44

Closed
mmanciop opened this issue Jun 9, 2021 · 4 comments · Fixed by #69
Closed

Reconsider alertmanager interface name #44

mmanciop opened this issue Jun 9, 2021 · 4 comments · Fixed by #69
Assignees

Comments

@mmanciop
Copy link
Contributor

mmanciop commented Jun 9, 2021

alertmanager is not a general relation name, it is more the interface of the relation. We need to find a more general name and use it as standard name for relations like "we push alerts".

@balbirthomas
Copy link
Contributor

@sed-i May I request you to pick this up as part of you refactor of the Alertmanager Charm library. Feel free to discuss suitable names on channel and with @mmanciop .

@sed-i sed-i changed the title Reconsider relation names Reconsider alertmanager relation name Jun 10, 2021
@sed-i
Copy link
Contributor

sed-i commented Jun 10, 2021

@balbirthomas
Copy link
Contributor

ATTN: @dstathis

@mmanciop
Copy link
Contributor Author

mmanciop commented Jul 4, 2021

edited for clarity:

We need to keep the relation interface unambiguous with:

  • other charms that receive alerts
  • other relation names that alertmanager may expose, see, e.g., the Karma ones

IMO, let’s call it alertmanager_dispatch

@sed-i sed-i changed the title Reconsider alertmanager relation name Reconsider alertmanager interface name Jul 5, 2021
@sed-i sed-i closed this as completed in #69 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants