Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests with fake timers to use modern implementation instead of legacy #487

Closed
bartaz opened this issue Jun 22, 2021 · 0 comments · Fixed by #534
Closed

Update tests with fake timers to use modern implementation instead of legacy #487

bartaz opened this issue Jun 22, 2021 · 0 comments · Fixed by #534
Labels
Priority: Low

Comments

@bartaz
Copy link
Contributor

bartaz commented Jun 22, 2021

This is a follow up to renovate PR that updated jest to 27: #485

Jest 26 introduced new implementation of fake timers. In jest 27 new timers implementation started to be default one and the previous one is called "legacy". Our tests are written with legacy timers in mind (so have to explicitly use this legacy version). We should look into what is needed to update our tests for new default timers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to using modern Jest fake timers Caleb-Ellis/react-components
1 participant
@bartaz