Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for consistency with other SD-Core charms #7

Merged
merged 3 commits into from May 31, 2023
Merged

Updates for consistency with other SD-Core charms #7

merged 3 commits into from May 31, 2023

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented May 30, 2023 •
edited

Description

Changes the workload container's image name for consistency with other SD-Core chams.
Updates the bindingIPv4 config param.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@Gmerold Gmerold requested a review from a team as a code owner May 30, 2023 08:41
@Gmerold Gmerold changed the title Updating workload image name Updates for consistency with other SD-Core charms May 30, 2023
sanchezfdezjavier
sanchezfdezjavier approved these changes May 30, 2023
View reviewed changes
Copy link

@sanchezfdezjavier sanchezfdezjavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the reminder, LGMT

@Gmerold Gmerold merged commit cf0b786 into main May 31, 2023
7 checks passed
@Gmerold Gmerold deleted the fix-workload-image-name-for-consistency branch May 31, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchezfdezjavier sanchezfdezjavier sanchezfdezjavier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gmerold @sanchezfdezjavier