Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect debian version comparison in v3.0.0 #58

Open
mssalvatore opened this issue Nov 20, 2020 · 1 comment
Open

Incorrect debian version comparison in v3.0.0 #58

mssalvatore opened this issue Nov 20, 2020 · 1 comment
Labels
bug Something isn't working v3.0.0

Comments

@mssalvatore
Copy link
Contributor

The v3.0.0 development version is currently using https://github.com/memory/python-dpkg to compare debian versions, however, there is a bug in the way python-dpkg compares versions. Inaccurate version comparisons will result in inaccurate scan results. To resolve this, either

A) Resolve the bug in python-dpkg and thoroughly inspect it for any more bugs that may be hiding.
B) Factor out the debian version comparison in review-tools into a standalone library that can be leveraged by both review-tools and CVEScan.
@mssalvatore mssalvatore added bug Something isn't working v3.0.0 labels Nov 20, 2020
@memory
Copy link

memory commented Nov 23, 2020

python-dpkg 1.5.0 has been released and should have resolved this bug. Thank you for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v3.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@memory @mssalvatore