Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core24] BuildPlanner is not reading the project's type correctly #4612

Closed
tigarmo opened this issue Feb 26, 2024 · 2 comments
Closed

[core24] BuildPlanner is not reading the project's type correctly #4612

tigarmo opened this issue Feb 26, 2024 · 2 comments
Labels
bug Actual bad behavior that don't fall into maintenance or documentation

Comments

@tigarmo
Copy link
Contributor

tigarmo commented Feb 26, 2024

Bug Description

The BuildPlanner in feature/craft-application reads a project_type value but the actual value is just type. This breaks builds that have, say, type: base because we end up passing None to get_effective_base()

To Reproduce

Run a project with type: base

Environment

Jammy

snapcraft.yaml

name: build-base-devel
version: '1.0'
summary: build-base-devel
description: Build a base snap with a build-base of devel
confinement: strict

type: base
build-base: devel

# grade must be devel when build-base is devel
grade: devel

parts:
  build-base-devel:
    plugin: nil
    stage-packages: [base-files]

Relevant log output

2024-02-23T22:32:05.2372678Z 2024-02-23 22:32:05 Error restoring google:ubuntu-22.04-64:tests/spread/core-devel/basic (feb232220-419390) : 
2024-02-23T22:32:05.2374371Z -----
2024-02-23T22:32:05.2375457Z + cd ./snap
2024-02-23T22:32:05.2376657Z + snapcraft clean
2024-02-23T22:32:05.2377675Z snapcraft internal error: KeyError('None')
2024-02-23T22:32:05.2379203Z Full execution log: '/root/.local/state/snapcraft/log/snapcraft-20240223-223205.003964.log'

Additional context

No response

@tigarmo tigarmo added the bug Actual bad behavior that don't fall into maintenance or documentation label Feb 26, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2542.

This message was autogenerated

@sergiusens
Copy link
Collaborator

Use Field to alias project_type to type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

No branches or pull requests

3 participants