postinst: fix service check for unattached machine #1891
Conversation
When running in a LTS machine with an architecture that is different from i386 and amd64 we will try to unconfigure esm services on these non-supported architectures. Before we unconfigure those services, we check to see if they are enabled. However, the code that performs that check is looking for a key in the status cache that is only present when machine is attached to a subscription. We are now updating the code to not fail if the machine is unattached. LP: #1951705 Fixes: canonical#1888
lucasmoura
force-pushed
the
fix-postinst-check-service-is-enabled
branch
from
9f24633
to
70d306e
Compare
|
@renanrodrigo code updated |
|
Hi, So, please merge it. |
|
Thanks for confirming this @OliverDrechsler |
|
What is reasonable time to expect this fix to arrive in following repository set?
Best regards, |
|
@Conrad-T-Pino We have already started the release process for this fix. |
|
@lucasmoura Thank you for the prompt reply. |
|
@Conrad-T-Pino just to let you know, we already have the package with the fix in the proposed pocket of jammy, in case you want to test it out. However, I saw in the bug that you were using the focal, so I will let you know when the package hits the proposed pocket for the other releases as well. |
|
@lucasmoura A general time frame is good enough. |
|
This fix remains unavailable from:
Best regards, |
|
Hi @Conrad-T-Pino, the package is already sitting in the We have uploaded the package last Friday, so it should be released today, but we avoid having package releases on older versions on Friday. Therefore, I strongly believe the package will be ready on Monday. However, if you want to test the version in Just be aware that more package could be sitting on that pocket besides ubuntu-advantage-client. Therefore, I suggest only upgrading that package directly. And I should have explained that process to you earlier, sorry for that. |
|
Hi @lucasmoura, thank you for the prompt unexpected response. My only concern is error free update to AWS EC2 arm64 instances so no explanations to my team are necessary. |
|
@Conrad-T-Pino the release with the fix is officially out. |
|
Error free update and upgrade at Mon 06 Dec 2021 11:23:52 AM PST:
|
|
@lucasmoura your care and interest over and above the necessary is seen and appreciated. Be safe and well. |
Proposed Commit Message
postinst: fix service check for unattached machine
When running in a LTS machine with an architecture that is different from i386 and amd64 we will try to unconfigure esm services on these non-supported architectures. Before we unconfigure those services, we check to see if they are enabled. However, the code that performs that check is looking for a key in the status cache that is only present when machine is attached to a subscription. We are now updating the code to not fail if the machine is unattached.
LP: #1951705
Fixes: #1888
Test Steps
To reproduce that error:
lxc launch ubuntu-daily:xenial dev-xua status/var/lib/dpkg/info/ubuntu-advantage-tools.postinstand change theESM_SUPPORTED_ARCHSvariable to be emptydpkg-reconfigure ubuntu-advantage-toolsDesired commit type
Checklist