Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python module uaclient conflicts with opcua-client-gui #2434

Open
renanrodrigo opened this issue Feb 10, 2023 · 2 comments
Open

Python module uaclient conflicts with opcua-client-gui #2434

renanrodrigo opened this issue Feb 10, 2023 · 2 comments

Comments

@renanrodrigo
Copy link
Member

https://github.com/FreeOpcUa/opcua-client-gui is using the same python module name as we do.
Users who install that tool on Ubuntu systems will have import errors if they pip it into their system Python configuration.

As https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2004482 shows, Desktop (software-properties-gtk) is importing us, and then failing because of that name conflict. This may not be the only case.

Maye we should at some point in time rename our modules, given we want to rename all ua-things anyway.

@orndorffgrant
Copy link
Collaborator

We need to rename our python module anyway, but we need to support
python-opcua, which uses the uaclient module name, is now deprecated in favor of opcua-asyncio. The old library is even removed from debian. Because of that migration, this bug is less important to fix, especially because we can't break older Ubuntu releases by changing our module name, so we'd only be able to fix the naming clash on newer Ubuntu releases that won't have python-opcua anyway. Since we can't fix this on releases where the naming clash exists, and the clash won't exist on future releases, I'm closing this issue. Please re-open if you disagree.

That being said, we will be changing our module name soon (likely to ubuntupro or similar). When we do that, we will still support importing from uaclient for existing Ubuntu releases, but we will probably remove our uaclient module for future Ubuntu releases, so that we don't hold two namespaces forever.

@orndorffgrant
Copy link
Collaborator

I made a mistake in my previous analysis. https://github.com/FreeOpcUa/python-opcua is indeed deprecated, but that is not the uaclient package. The conflicting package is https://github.com/FreeOpcUa/opcua-client-gui which is still supported.

So we should rename our module to prevent clashes in the future.

fyi @lucasmoura @renanrodrigo

@orndorffgrant orndorffgrant reopened this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants