Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WD-10435 - intel iot page rebrand #13970

Merged
merged 12 commits into from
Jul 1, 2024
Merged

WD-10435 - intel iot page rebrand #13970

merged 12 commits into from
Jul 1, 2024

Conversation

lizzochek
Copy link
Contributor

@lizzochek lizzochek commented Jun 20, 2024 •
edited by juanruitina
Loading

Done

Rebrand intel-iot page.

QA

  • demo link
  • copy doc
  • figma
  • View the site on demo
  • Run through the following QA steps
  • Check that the page is correctly updated according to copy doc and figma

Issue / Card

WD-10435

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.12%. Comparing base (0277528) to head (0a75e8f).
Report is 58 commits behind head on main.

❗ Current head 0a75e8f differs from pull request most recent head a2daf01

Please upload reports for the commit a2daf01 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13970   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         107      107           
  Lines        2864     2864           
  Branches      957      957           
=======================================
  Hits         2123     2123           
  Misses        715      715           
  Partials       26       26

see 1 file with indirect coverage changes

@juanruitina
Apply minor style and markup changes
001b270 
Improve tab styling
Improve heading hierarchy
Tweak HR spacings
@juanruitina
Hide HRs on medium/small
cd9a869
@juanruitina
Copy link
Contributor

There were a handful of repetitive small tweaks needed, so I went ahead and applied them myself. Hope that's OK.

There's some weird behaviour of the equal heights component on medium screens (see below), what can we do about it? Just stacking the three boxes would do the trick for me. / @lyubomir-popov

Screenshot 2024-06-21 at 12 20 39

@lyubomir-popov
Copy link
Contributor

this h2 needs to be wrapped in a p-section--shallow:
image

@lyubomir-popov
Copy link
Contributor

There's some weird behaviour of the equal heights component on medium screens (see below), what can we do about it? Just stacking the three boxes would do the trick for me. / @lyubomir-popov

I think they are just stacking, that's why it looks a little under designed. Or did you have something else in mind?

@lyubomir-popov
Copy link
Contributor

@juanruitina oh the markup is incorrect, this is what it should be like:
image

@lizzochek
Copy link
Contributor Author

@juanruitina @lyubomir-popov updated according to your comments

@lyubomir-popov
Copy link
Contributor

these two should be in a single code snippet, at the moment theres two pres, causing too much space between lines
image

this looks wrong - 2 "ands", 3 times the amount of text that should be in a title - @Sophie-32 is it possible to shorten or breakoff part of the heading and put it in a paragraph following the heading?:
image

the last section before the footer on every page should have p-section--deep on it, to doulbe the amount of white space at the bottom:
image

akbarkz
akbarkz requested changes Jun 28, 2024
View reviewed changes
templates/download/iot/intel-iot.html Outdated Show resolved Hide resolved
templates/download/iot/intel-iot.html Outdated Show resolved Hide resolved
templates/download/iot/intel-iot.html Outdated Show resolved Hide resolved
templates/download/iot/intel-iot.html Outdated Show resolved Hide resolved
akbarkz
akbarkz reviewed Jul 1, 2024
View reviewed changes
templates/download/iot/intel-iot.html Outdated Show resolved Hide resolved
templates/download/iot/intel-iot.html Outdated
</li>
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/66ac0a18-LookoutCanyon_ReleaseNotes_22.04_230330_V1.1.pdf">Release
notes for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html
</li>
<li class="p-inline-list__item">
<a href="https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890">Release
notes for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html Outdated
</li>
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/fd2fa325-LookoutCanyon_ReleaseNotes_20.04_221115_V1.1.pdf">Release
notes for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html Outdated
</li>
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/66ac0a18-LookoutCanyon_ReleaseNotes_22.04_230330_V1.1.pdf">Release
notes for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html Outdated
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/66ac0a18-LookoutCanyon_ReleaseNotes_22.04_230330_V1.1.pdf">Release
notes
for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html Outdated
</li>
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/66ac0a18-LookoutCanyon_ReleaseNotes_22.04_230330_V1.1.pdf">Release
notes for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html Outdated
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/66ac0a18-LookoutCanyon_ReleaseNotes_22.04_230330_V1.1.pdf">Release
notes
for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html Outdated
</li>
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/66ac0a18-LookoutCanyon_ReleaseNotes_22.04_230330_V1.1.pdf">Release
notes for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

templates/download/iot/intel-iot.html Outdated
</li>
<li class="p-inline-list__item">
<a href="https://assets.ubuntu.com/v1/66ac0a18-LookoutCanyon_ReleaseNotes_22.04_230330_V1.1.pdf">Release
notes for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white space

@lizzochek lizzochek merged commit e2093c1 into canonical:main Jul 1, 2024
13 checks passed
britneywwc pushed a commit to britneywwc/ubuntu.com that referenced this pull request Jul 5, 2024
@lizzochek @britneywwc
WD-10435 - intel iot page rebrand (canonical#13970)
3589c69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akbarkz akbarkz akbarkz approved these changes

Assignees

@juanruitina juanruitina

@lyubomir-popov lyubomir-popov

Labels
Review: Code +1 (with changes) Review: Design +1 Review: QA +1 Review: UX +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lizzochek @webteam-app @juanruitina @lyubomir-popov @akbarkz @Sophie-32