Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable shop for external users and buy button #14039

Merged
merged 1 commit into from
Jul 4, 2024
Merged

disable shop for external users and buy button #14039

merged 1 commit into from
Jul 4, 2024

Conversation

usamabinnadeem-10
Copy link
Contributor

Done

  • Remove buy button
  • Disable shop for non canonical users

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Go to /credentials, Buy button should not show up
  • Sign in as a non canonical.com user and /credentials/shop should throw an Unauthorised error message

Issue / Card

Fixes Jira

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@usamabinnadeem-10 usamabinnadeem-10 merged commit 8154453 into main Jul 4, 2024
26 checks passed
@usamabinnadeem-10 usamabinnadeem-10 deleted the WD-12994-remove-buy-button-from-home branch July 4, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhigyanghosh30 abhigyanghosh30 abhigyanghosh30 approved these changes

Assignees

@abhigyanghosh30 abhigyanghosh30

@usamabinnadeem-10 usamabinnadeem-10

Labels
Commercial 🛒 🧊 Credentials Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@usamabinnadeem-10 @webteam-app @abhigyanghosh30