Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid does not work in IE 11 #2685

Closed
bartaz opened this issue Dec 3, 2019 · 3 comments · Fixed by #2943
Closed

Grid does not work in IE 11 #2685

bartaz opened this issue Dec 3, 2019 · 3 comments · Fixed by #2943
Assignees
Labels
Priority: High Should be addressed within current iteration WG: Validated Validate working group proposals

Comments

@bartaz
Copy link
Contributor

bartaz commented Dec 3, 2019

Browser support page claims Vanilla is actively tested in IE 11.
This doesn't seem to be true.

Recently introduced CSS grid is not supported by IE and does not work properly.

In most basic case grid elements are just rendered one under another (which could be considered graceful degradation):
Screenshot 2019-12-03 at 15 21 49

But there are cases (like snapcraft.io), where Vanilla grid breaks completely making content of the page unreadable:
Screenshot 2019-12-03 at 15 27 24

Expected behavior
We should make sure that all the components are tested in browsers that we claim they are.
Ideally we should make the grid work in IE 11 (by applying polyfill or fallback syntax - IE 11 seems to be supporting old CSS grid syntax, so maybe autoprefixer can be used to make it work?).

If we don't want to support IE 11 and older versions, we should stop claiming the support on the website.

Desktop (please complete the following information):

  • OS: Windows
  • Browser IE 11
@cristinadresch cristinadresch added the Priority: High Should be addressed within current iteration label Dec 5, 2019
@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Jan 7, 2020

I can address the prefixing part of this. I've created a separate issue for it.

@bartaz
Copy link
Contributor Author

bartaz commented Feb 21, 2020

It seems we can't simply prefix the grid for IE because of lack of support for autoplacement.

We should discuss how to approach fixing the grid for IE.

@bartaz bartaz added the WG: Proposal Working group proposals label Feb 21, 2020
@bartaz
Copy link
Contributor Author

bartaz commented Feb 24, 2020

WG:

  • investigate when it breaks in IE11
  • use supports to detect support for grid and provide flexbox implementation for columns
    • if real grid support is hard to maintain, simplyfy the view
  • discuss testing in IE11 to make sure we keep supporting it

@bartaz bartaz added WG: Validated Validate working group proposals and removed WG: Proposal Working group proposals labels Feb 24, 2020
@bartaz bartaz added this to the Iteration 20-11 milestone Mar 5, 2020
@bartaz bartaz self-assigned this Mar 23, 2020
@lyubomir-popov lyubomir-popov self-assigned this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Should be addressed within current iteration WG: Validated Validate working group proposals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants