Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing borders from subnav dropdown #2765

Closed
bartaz opened this issue Jan 21, 2020 · 5 comments · Fixed by #2925
Closed

Consider removing borders from subnav dropdown #2765

bartaz opened this issue Jan 21, 2020 · 5 comments · Fixed by #2925
Assignees
Labels
Priority: Low WG: Validated Validate working group proposals

Comments

@bartaz
Copy link
Contributor

bartaz commented Jan 21, 2020

Pattern to amend

Sub navigation

Context

@lyubomir-popov commented on a PR with subnav fixes suggesting that we don't need these borders:
#2761 (comment)

This will simplify the look and allow to remove some code that adds these borders, hides them on mobile, etc.

Visual

Current:

Screenshot 2020-01-21 at 10 39 38

Without border:

Screenshot 2020-01-21 at 10 41 03

Provide a screenshot or link to a prototype of your pattern amendment.

@bartaz bartaz added the WG: Proposal Working group proposals label Jan 21, 2020
@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Jan 22, 2020

@spencerbygraves @bartaz

I've made a bit of preliminary exploration, but we should put this on hold until we finish the sidebar design work, as the two need to be aligned. The contextual menu too, potentially. The ones in the middle look most promising I think.

Here's where I got to, key issues to think about:

  • styling should be similar between mobile and desktop versions, e.g. if we introduce a background for the subnav,s that should happen in bot hplaces
  • we have places where, depending on the solution, a background might extend beyond the width of the dividers - which is a bit awkward, so something to consider
  • drop shadow is a necessity in all desktop cases, as we don't know what is going to be underneath
    Border alternative Copy 2
    Border alternative Copy]

@spencerbygraves spencerbygraves added WG: Validated Validate working group proposals and removed WG: Proposal Working group proposals labels Jan 27, 2020
@spencerbygraves
Copy link

WG: agreed to work on this as part of the side nav project.

@bartaz
Copy link
Contributor Author

bartaz commented Feb 24, 2020

@spencerbygraves @lyubomir-popov

Seems we decided this should be a part of sidebar nav project. Not sure how does it fit into designs you are creating now? Can the navigation dropdowns be considered there as well (to have consistent styling with side nav)?

@bartaz
Copy link
Contributor Author

bartaz commented Mar 5, 2020

Sidebar nav started, let's wait until we implement it.

@spencerbygraves
Copy link

@bartaz this was waiting for the sidebar designs to see if it can share styling. I think we can remove it from the sidebar epic and @lyubomir-popov can work on the designs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low WG: Validated Validate working group proposals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants