Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base button is white on grey background #3779

Closed
bartaz opened this issue Jun 8, 2021 · 2 comments · Fixed by #3807
Closed

Base button is white on grey background #3779

bartaz opened this issue Jun 8, 2021 · 2 comments · Fixed by #3807
Assignees
Labels
Bug 🐛 Priority: High Should be addressed within current iteration

Comments

@bartaz
Copy link
Contributor

bartaz commented Jun 8, 2021

Describe the bug

In 2.31.0 the background of base button was changed from transparent to white. It makes the button visible on lightgrey backgrounds (like MAAS) when it was not visible before.

Screenshot 2021-06-08 at 08 51 20

Expected behavior

Screenshot 2021-06-08 at 08 55 01

Context

This blocks MAAS update to 2.31.0: canonical/maas-ui#2736

@bartaz bartaz added the Bug 🐛 label Jun 8, 2021
@lyubomir-popov
Copy link
Contributor

The base button used to be invisible on dark background, e.g. here:
image

Seems we need 2 things:

  • transparent button that works on white and gray
  • a button that works within dark elements, posibly not whie as that inverts the perception of primary-ness compared to the green

@bartaz
Copy link
Contributor Author

bartaz commented Jun 8, 2021

@lyubomir-popov it may still be 1 thing, if the "transparent" base button works on dark backgrounds as well (with appropriate text and hover colors)

@cristinadresch cristinadresch added the Priority: High Should be addressed within current iteration label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Priority: High Should be addressed within current iteration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants