Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo spacing wrong #4789

Closed
lyubomir-popov opened this issue Jun 14, 2023 · 3 comments · Fixed by #4924
Closed

Logo spacing wrong #4789

lyubomir-popov opened this issue Jun 14, 2023 · 3 comments · Fixed by #4924
Assignees
@aaryanporwal
Labels
Bug 🐛 Guest dev 🤝 Good issue to work on with guest devs

Comments

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Jun 14, 2023 •
edited

Can we please increase the spacing between text and tag by 3px? This amount was discussed with @marcushas in the visual design meeting.

image
@lyubomir-popov
Copy link
Contributor Author

(assuming the current snapcraft page is a reflection of what is currently in vanilla)

@bartaz
Copy link
Contributor

bartaz commented Jun 14, 2023

3px won't scale up with the font size. Should we reflect that in rems?

@lyubomir-popov
Copy link
Contributor Author

yes can be in rems, thanks.

@bartaz bartaz added Bug 🐛 Guest dev 🤝 Good issue to work on with guest devs labels Nov 23, 2023
@aaryanporwal aaryanporwal mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaryanporwal aaryanporwal

Labels
Bug 🐛 Guest dev 🤝 Good issue to work on with guest devs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more space between logo tag and text aaryanporwal/vanilla-framework
3 participants
@bartaz @lyubomir-popov @aaryanporwal