Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

row--25-75 - col containers do not set grid context properly #5032

Closed
lyubomir-popov opened this issue Mar 22, 2024 · 1 comment
Closed

row--25-75 - col containers do not set grid context properly #5032

lyubomir-popov opened this issue Mar 22, 2024 · 1 comment
Labels

Comments

@lyubomir-popov
Copy link
Contributor

Describe the bug
Paste this in a vanilla example, turn on the grid visualisation. You'll see 0 width columns, indicating the grid thinks it has more columns available than it does

image

<div class="row--25-75">
    
    <div class="col">
      <h2 class="p-heading--2">Resources</h2>
    </div>
    <div class="col">
      
      
     <div class="row">
        <div class="col-medium-1">
          <h3 class="p-heading--5" data-gtm-vis-recent-on-screen1014405_499="195" data-gtm-vis-first-on-screen1014405_499="195" data-gtm-vis-total-visible-time1014405_499="100" data-gtm-vis-has-fired1014405_499="1">eBook</h3>
        </div>
        <div class="col-medium-3">
          <p data-gtm-vis-has-fired1014405_503="1"><a href="https://pages.ubuntu.com/Forrester_TAP_Report_2016.html">Forrester Research - get more from the cloud</a></p>

        </div>
      </div>
      
      
    </div>
  </div>

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

@bartaz
Copy link
Contributor

bartaz commented Mar 22, 2024

This is due to the fact that there are no col-X class names for desktop at all. They need to be specified.

It's not a Vanilla bug. We have a separate issue open to fix deeper nesting of the grids.

@bartaz bartaz closed this as completed Mar 22, 2024
@bartaz bartaz reopened this Mar 22, 2024
@bartaz bartaz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants