Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add left and right chevrons to vanilla icon set #5066

Open
camillet16 opened this issue Apr 24, 2024 · 4 comments
Open

Add left and right chevrons to vanilla icon set #5066

camillet16 opened this issue Apr 24, 2024 · 4 comments
Labels
Feature 🎁 New feature or request

Comments

@camillet16
Copy link

A component in Vanilla needs to be flexible enough that it can be used across a wide range of scenarios and shouldn't be constrained to a specific number of applications.

Visual

Screenshot 2024-04-24 at 4 29 14 PM

Context

at the moment we're using rotated up and down buttons. It's being used across multiple products

State

The same states as other vanilla. icons

Progressive enhancement

since it's an icon it works across all screens

@camillet16 camillet16 added the WG: Proposal Working group proposals label Apr 24, 2024
@bartaz
Copy link
Contributor

bartaz commented Apr 24, 2024

If we have SVGs for the icons, we can add those to the icon set I guess.

@camillet16
Copy link
Author

@bartaz we do have them i'll upload them onto the assets

@bartaz
Copy link
Contributor

bartaz commented Apr 24, 2024

@camillet16 for Vanilla they don't need to be in assets, as we inline them in CSS.

Are there in icons drive folder (could you link those)? Or add them to comment here, and I can use the files to add to Vanilla CSS.

@camillet16
Copy link
Author

chevron-left
chevron-right

Here they are. I'm not sure if they're on a drive somewhere.

@bartaz bartaz added Feature 🎁 New feature or request and removed WG: Proposal Working group proposals labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 🎁 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants