You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The color theme selection control on the docs/examples pages always shows "Dark" as the selected theme. On initial load, it appears to default to "Light" theme but shows "Dark" as active. Clicking the theme buttons changes the theme for supported components but does not update which theme is highlighted in the theme selector; Dark theme is always highlighted.
Yes, the issue is there is no "selected" style at all in the picker. The style of the buttons reflects the theme itself, but none have a selected state.
It was kind of quickly hacked in when we worked on theming migration with guests, so it's not ideal.
One issue you may get into is that currently Vanilla examples are not implementing the themes in consistent way, and not all of them have a default class name set on body, so it's not always trivial to tell which is the "current" theme when example loads.
Another cool feature we could introduce would be to reflect the theme in the URL /example?theme=dark and make it load in desired theme. This would allow us to easier test the same example in different themes just by changing the URL.
Feel free to play around during this week, and maybe we can turn this into something you could be working on while we are in Madrid.
Describe the bug
The color theme selection control on the
docs/examples
pages always shows "Dark" as the selected theme. On initial load, it appears to default to "Light" theme but shows "Dark" as active. Clicking the theme buttons changes the theme for supported components but does not update which theme is highlighted in the theme selector; Dark theme is always highlighted.To Reproduce
Steps to reproduce the behavior:
/docs/examples
page. For example, https://vanillaframework.io/docs/examples/base/detailsExpected behavior
The color theme picker always highlights the button for the currently selected color theme.
Screenshots
Desktop:
The text was updated successfully, but these errors were encountered: