You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, Vanilla is not creating any mixins for specific directional chevrons. Rather, we create a single mixin vf-p-icon-chevron that declares classes for the directional chevrons. The information icon is included in the mixin vf-p-icon-info, not vf-p-icon-information.
Attempting to include these as directed by our documentation will lead to a build error as the mixins cannot be found.
To Reproduce
Steps to reproduce the behavior:
Icons documentation imports section
Observe the instructions to include the above mixins
Verify that there is no mixin in the Vanilla codebase matching any of the above.
Expected behavior
The icons import documentation accurately reflects how to import the minimum set of SCSS required to show each icon.
Screenshots
Desktop (please complete the following information):
OS: PopOS 22.04
Browser: Firefox
Version: 125.0.2
Additional Context
The icons documentation is creating the import statements by looping through standard_icons in templates/docs/patterns/icons/index.md (which also controls which icons are displayed in the standard & dark theme icons sections).
Removing the instructions to import these nonexistent mixins would require slight changes around here to avoid creating import statements for specific mixins. Maybe it's easier to implement the mixins themselves?
Maybe we should create mixins for each direction, or remove the specific directional chevrons from the documentation and direct users to just include vf-p-icon-chevron.
The text was updated successfully, but these errors were encountered:
Describe the bug
The import section of the icons documentation suggests that users can specifically include directional chevrons and the information icon by name:
However, Vanilla is not creating any mixins for specific directional chevrons. Rather, we create a single mixin vf-p-icon-chevron that declares classes for the directional chevrons. The information icon is included in the mixin
vf-p-icon-info
, notvf-p-icon-information
.Attempting to include these as directed by our documentation will lead to a build error as the mixins cannot be found.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The icons import documentation accurately reflects how to import the minimum set of SCSS required to show each icon.
Screenshots
Desktop (please complete the following information):
Additional Context
The icons documentation is creating the import statements by looping through
standard_icons
intemplates/docs/patterns/icons/index.md
(which also controls which icons are displayed in the standard & dark theme icons sections).Removing the instructions to import these nonexistent mixins would require slight changes around here to avoid creating import statements for specific mixins. Maybe it's easier to implement the mixins themselves?
Maybe we should create mixins for each direction, or remove the specific directional chevrons from the documentation and direct users to just include
vf-p-icon-chevron
.The text was updated successfully, but these errors were encountered: