Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Systems with duplicate names can show incorrect POI data #124

Open
teptec opened this issue Feb 26, 2022 · 2 comments
Open

[BUG] Systems with duplicate names can show incorrect POI data #124

teptec opened this issue Feb 26, 2022 · 2 comments
Assignees
Labels

Comments

@teptec
Copy link
Contributor

teptec commented Feb 26, 2022

When getPOIdata calls the query/getSystemPoi endpoint it passes the system name.
This is generally fine, but with systems with duplicate names it doesn't return the correct results.

An example is system: 2MASS J03292155+3121104

In system with id 5063630988321, planet 5 has a Thick Methane-rich atmosphere and no biological signals.
In system with id 18256696452033, planet 5 has a Thin Neon atmosphere and is home to a Bacterium Acies - Magenta.

Because the API is called with system name, the EDMC plugin reports Bacterium Acies on the Thick Methane-rich body:

image

This is in system 5063630988321:
image

But the data for Biology relates to system 18256696452033 where planet 5 has a Neon atmosphere:
image

It's worth noting that the canonn-signals page (neon and methane) and the biostats endpoint are passed the Id64 and show correct data.
The ideal solution would be to implement a query/getSystemPoiById64 which EDMC-Canonn can call, passing the Id64.

@NoFoolLikeOne
Copy link
Collaborator

I intend to switch to spansh at some point and will use the id64 to fetch data and then this will go away

@NoFoolLikeOne
Copy link
Collaborator

Need to update plugin to pass id64 to getPOIdata and then only return data if ID64 and SystemName both match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants