Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with nightly 98aa3624b 2024-02-08 in ahash-0.8.2 #168

Closed
mbuesch opened this issue Feb 9, 2024 · 4 comments · Fixed by #169
Closed

Fails to build with nightly 98aa3624b 2024-02-08 in ahash-0.8.2 #168

mbuesch opened this issue Feb 9, 2024 · 4 comments · Fixed by #169

Comments

@mbuesch
Copy link

mbuesch commented Feb 9, 2024

bacon fails to build with nightly:

error[E0635]: unknown feature `stdsimd`
  --> /.../rust-nightly/cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.2/src/lib.rs:99:42
   |
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |                                          ^^^^^^^

Note that ahash-0.8.2 is yanked.

@Canop
Copy link
Owner

Canop commented Feb 9, 2024

At first sight it looks like it would be enough to have this in the dependencies:

ahash = "0.8.7"
gix = "0.40"

but it's probably possible to try having a more recent version of gix, this will need some work. And maybe I can completely clean the Cargo.lock, I'll have a look.

@mbuesch
Copy link
Author

mbuesch commented Feb 9, 2024

I also tried with running cargo update first, but than it fails at a different place for a different reason.
So currently --locked and not--locked fails on nightly.

@Canop Canop mentioned this issue Feb 9, 2024
@Canop
Copy link
Owner

Canop commented Feb 9, 2024

@mbuesch Tests of the PR would be welcome.

@mbuesch
Copy link
Author

mbuesch commented Feb 9, 2024

I confirm that branch 57719f1 fixes the build issue.
Thanks a lot for your quick help :)

Canop added a commit that referenced this issue Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants