Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-token not anchored patterns not correctly recognized by gitignore filter #35

Open
Canop opened this issue Feb 22, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@Canop
Copy link
Owner

Canop commented Feb 22, 2019

If your .gitignore contains

a/b/c

(that is a multi-token pattern not starting with a /)

then git would ignore the

$project_root/a/b/c

file, but broot wouldn't filter it out.

This looks like a limitation (a bug?) of the glob lib I use (https://docs.rs/glob/0.2.11/glob/).

@Canop Canop added the bug Something isn't working label Feb 22, 2019
@rlue
Copy link

rlue commented Jan 1, 2021

Conversely, if your gitignore file is whitelist-based:

# .gitignore
/*

!/a/b/c

then (IMO) you should be able to navigate to a/b/c with gi:y in broot, but a is filtered out.

@Canop
Copy link
Owner Author

Canop commented Jan 1, 2021

@rlue this should probably a a different issue. It's less a bug than a problem of finding the right specification (which isn't obvious for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants